Commit d09e973f authored by Dmitry Timoshkov's avatar Dmitry Timoshkov Committed by Alexandre Julliard

user32: Add an invalid window check to SetFocus.

parent 94ffc49e
...@@ -259,6 +259,11 @@ HWND WINAPI SetFocus( HWND hwnd ) ...@@ -259,6 +259,11 @@ HWND WINAPI SetFocus( HWND hwnd )
{ {
/* Check if we can set the focus to this window */ /* Check if we can set the focus to this window */
hwnd = WIN_GetFullHandle( hwnd ); hwnd = WIN_GetFullHandle( hwnd );
if (!IsWindow( hwnd ))
{
SetLastError( ERROR_INVALID_WINDOW_HANDLE );
return 0;
}
if (hwnd == previous) return previous; /* nothing to do */ if (hwnd == previous) return previous; /* nothing to do */
for (;;) for (;;)
{ {
......
...@@ -13573,10 +13573,9 @@ static void test_SetFocus(void) ...@@ -13573,10 +13573,9 @@ static void test_SetFocus(void)
SetLastError(0xdeadbeef); SetLastError(0xdeadbeef);
old_focus = SetFocus((HWND)0xdeadbeef); old_focus = SetFocus((HWND)0xdeadbeef);
todo_wine
ok(GetLastError() == ERROR_INVALID_WINDOW_HANDLE, "expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); ok(GetLastError() == ERROR_INVALID_WINDOW_HANDLE, "expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError());
while (PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) DispatchMessage(&msg); while (PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) DispatchMessage(&msg);
ok_sequence(WmEmptySeq, "SetFocus on an invalid window", TRUE); ok_sequence(WmEmptySeq, "SetFocus on an invalid window", FALSE);
ok(old_focus == 0, "expected old focus 0, got %p\n", old_focus); ok(old_focus == 0, "expected old focus 0, got %p\n", old_focus);
ok(GetActiveWindow() == parent, "expected active %p, got %p\n", parent, GetActiveWindow()); ok(GetActiveWindow() == parent, "expected active %p, got %p\n", parent, GetActiveWindow());
ok(GetFocus() == parent, "expected focus %p, got %p\n", parent, GetFocus()); ok(GetFocus() == parent, "expected focus %p, got %p\n", parent, GetFocus());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment