wininet: Fix a use-after-free (Coverity).

pEntry could be freed after cache_container_unlock_index(pContainer, pHeader).

wininet: Fix a use-after-free (Coverity).
d36f50c4 · Zhiyi Zhang · Alexandre Julliard · 1a6deb1c · d36f50c4
Commit d36f50c4 authored Dec 02, 2023 by Zhiyi Zhang Committed by Alexandre Julliard Dec 04, 2023
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

urlcache.c dlls/wininet/urlcache.c +1 -1

No files found.
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -2550,8 +2550,8 @@ BOOL WINAPI UnlockUrlCacheEntryFileA(LPCSTR lpszUrlName, DWORD dwReserved)
    pEntry = (entry_header*)((LPBYTE)pHeader + pHashEntry->offset);
    if (pEntry->signature != URL_SIGNATURE)
    {
-        cache_container_unlock_index(pContainer, pHeader);
        FIXME("Trying to retrieve entry of unknown format %s\n", debugstr_an((LPSTR)&pEntry->signature, sizeof(DWORD)));
+        cache_container_unlock_index(pContainer, pHeader);
        SetLastError(ERROR_FILE_NOT_FOUND);
        return FALSE;
    }