ole32: Add error checking to StorageBaseImpl_CreateStorage.

d420a858 · Vincent Povirk · Alexandre Julliard · 1fab6e35 · d420a858
Commit d420a858 authored Feb 13, 2010 by Vincent Povirk Committed by Alexandre Julliard Feb 15, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 2 deletions

storage32.c dlls/ole32/storage32.c +9 -2

No files found.
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -1132,15 +1132,22 @@ static HRESULT WINAPI StorageBaseImpl_CreateStorage(
  /*
   * Create a new directory entry for the storage
   */
-  StorageBaseImpl_CreateDirEntry(This, &newEntry, &newEntryRef);
+  hr = StorageBaseImpl_CreateDirEntry(This, &newEntry, &newEntryRef);
+  if (FAILED(hr))
+    return hr;

  /*
   * Insert the new directory entry into the parent storage's tree
   */
-  insertIntoTree(
+  hr = insertIntoTree(
    This,
    This->storageDirEntry,
    newEntryRef);
+  if (FAILED(hr))
+  {
+    StorageBaseImpl_DestroyDirEntry(This, newEntryRef);
+    return hr;
+  }

  /*
   * Open it to get a pointer to return.