win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck).

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck).
d45d54ef · Alex Henrie · Alexandre Julliard · cf7dd520 · d45d54ef
Commit d45d54ef authored Dec 20, 2021 by Alex Henrie Committed by Alexandre Julliard Dec 20, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

path.c dlls/win32u/path.c +5 -3

No files found.
--- a/dlls/win32u/path.c
+++ b/dlls/win32u/path.c
@@ -1616,7 +1616,7 @@ BOOL WINAPI NtGdiFlattenPath( HDC hdc )
 static struct gdi_path *PATH_WidenPath(DC *dc)
 {
    INT i, j, numStrokes, penWidth, penWidthIn, penWidthOut, size, penStyle;
-    struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, *pUpPath, *pDownPath;
+    struct gdi_path *flat_path, *pNewPath, **pStrokes = NULL, **new_strokes, *pUpPath, *pDownPath;
    EXTLOGPEN *elp;
    BYTE *type;
    DWORD obj_type, joint, endcap, penType;
@@ -1681,12 +1681,14 @@ static struct gdi_path *PATH_WidenPath(DC *dc)
            case PT_MOVETO:
                numStrokes++;
                j = 0;
-                pStrokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) );
+                new_strokes = realloc( pStrokes, numStrokes * sizeof(*pStrokes) );
-                if(!pStrokes)
+                if (!new_strokes)
                {
                    free_gdi_path(flat_path);
+                    free(pStrokes);
                    return NULL;
                }
+                pStrokes = new_strokes;
                pStrokes[numStrokes - 1] = alloc_gdi_path(0);
                /* fall through */
            case PT_LINETO: