Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
db8ff72f
Commit
db8ff72f
authored
Apr 03, 2014
by
Nikolay Sivov
Committed by
Alexandre Julliard
Apr 03, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Handle NULL child in appendChild().
parent
c22cdeea
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
0 deletions
+9
-0
node.c
dlls/msxml3/node.c
+3
-0
domdoc.c
dlls/msxml3/tests/domdoc.c
+6
-0
No files found.
dlls/msxml3/node.c
View file @
db8ff72f
...
@@ -625,6 +625,9 @@ HRESULT node_append_child(xmlnode *This, IXMLDOMNode *child, IXMLDOMNode **outCh
...
@@ -625,6 +625,9 @@ HRESULT node_append_child(xmlnode *This, IXMLDOMNode *child, IXMLDOMNode **outCh
VARIANT
var
;
VARIANT
var
;
HRESULT
hr
;
HRESULT
hr
;
if
(
!
child
)
return
E_INVALIDARG
;
hr
=
IXMLDOMNode_get_nodeType
(
child
,
&
type
);
hr
=
IXMLDOMNode_get_nodeType
(
child
,
&
type
);
if
(
FAILED
(
hr
)
||
type
==
NODE_ATTRIBUTE
)
{
if
(
FAILED
(
hr
)
||
type
==
NODE_ATTRIBUTE
)
{
if
(
outChild
)
*
outChild
=
NULL
;
if
(
outChild
)
*
outChild
=
NULL
;
...
...
dlls/msxml3/tests/domdoc.c
View file @
db8ff72f
...
@@ -8878,6 +8878,12 @@ static void test_appendChild(void)
...
@@ -8878,6 +8878,12 @@ static void test_appendChild(void)
EXPECT_NO_CHILDREN
(
doc
);
EXPECT_NO_CHILDREN
(
doc
);
EXPECT_NO_CHILDREN
(
doc2
);
EXPECT_NO_CHILDREN
(
doc2
);
hr
=
IXMLDOMDocument_appendChild
(
doc2
,
NULL
,
NULL
);
ok
(
hr
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
hr
=
IXMLDOMElement_appendChild
(
elem
,
NULL
,
NULL
);
ok
(
hr
==
E_INVALIDARG
,
"got 0x%08x
\n
"
,
hr
);
/* append from another document */
/* append from another document */
hr
=
IXMLDOMDocument_appendChild
(
doc2
,
(
IXMLDOMNode
*
)
elem
,
NULL
);
hr
=
IXMLDOMDocument_appendChild
(
doc2
,
(
IXMLDOMNode
*
)
elem
,
NULL
);
ok
(
hr
==
S_OK
,
"got 0x%08x
\n
"
,
hr
);
ok
(
hr
==
S_OK
,
"got 0x%08x
\n
"
,
hr
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment