Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
dc33b135
Commit
dc33b135
authored
Mar 27, 2014
by
Nikolay Sivov
Committed by
Alexandre Julliard
Mar 27, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix a record leak on error paths (Coverity).
parent
d78a0612
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
3 deletions
+8
-3
custom.c
dlls/msi/custom.c
+8
-3
No files found.
dlls/msi/custom.c
View file @
dc33b135
...
...
@@ -1003,7 +1003,7 @@ static UINT HANDLE_CustomType5_6( MSIPACKAGE *package, const WCHAR *source, cons
'S'
,
'E'
,
'L'
,
'E'
,
'C'
,
'T'
,
' '
,
'*'
,
' '
,
'F'
,
'R'
,
'O'
,
'M'
,
' '
,
'`'
,
'B'
,
'i'
,
'n'
,
'a'
,
'r'
,
'y'
,
'`'
,
' '
,
'W'
,
'H'
,
'E'
,
'R'
,
'E'
,
' '
,
'`'
,
'N'
,
'a'
,
'm'
,
'e'
,
'`'
,
' '
,
'='
,
' '
,
'\''
,
'%'
,
's'
,
'\''
,
0
};
MSIRECORD
*
row
=
0
;
MSIRECORD
*
row
=
NULL
;
msi_custom_action_info
*
info
;
CHAR
*
buffer
=
NULL
;
WCHAR
*
bufferw
=
NULL
;
...
...
@@ -1017,10 +1017,14 @@ static UINT HANDLE_CustomType5_6( MSIPACKAGE *package, const WCHAR *source, cons
return
ERROR_FUNCTION_FAILED
;
r
=
MSI_RecordReadStream
(
row
,
2
,
NULL
,
&
sz
);
if
(
r
!=
ERROR_SUCCESS
)
return
r
;
if
(
r
!=
ERROR_SUCCESS
)
goto
done
;
buffer
=
msi_alloc
(
sz
+
1
);
if
(
!
buffer
)
return
ERROR_FUNCTION_FAILED
;
if
(
!
buffer
)
{
r
=
ERROR_FUNCTION_FAILED
;
goto
done
;
}
r
=
MSI_RecordReadStream
(
row
,
2
,
buffer
,
&
sz
);
if
(
r
!=
ERROR_SUCCESS
)
...
...
@@ -1040,6 +1044,7 @@ static UINT HANDLE_CustomType5_6( MSIPACKAGE *package, const WCHAR *source, cons
done
:
msi_free
(
bufferw
);
msi_free
(
buffer
);
msiobj_release
(
&
row
->
hdr
);
return
r
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment