Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
df53b501
Commit
df53b501
authored
Nov 27, 2012
by
Jacek Caban
Committed by
Alexandre Julliard
Nov 27, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Fixed a few coverity issues.
parent
71d185d7
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
28 additions
and
14 deletions
+28
-14
navigate.c
dlls/mshtml/navigate.c
+8
-8
nsembed.c
dlls/mshtml/nsembed.c
+1
-0
nsio.c
dlls/mshtml/nsio.c
+9
-3
pluginhost.c
dlls/mshtml/pluginhost.c
+3
-1
protocol.c
dlls/mshtml/protocol.c
+7
-2
No files found.
dlls/mshtml/navigate.c
View file @
df53b501
...
...
@@ -800,15 +800,16 @@ HRESULT start_binding(HTMLInnerWindow *inner_window, BSCallback *bscallback, IBi
/* NOTE: IE7 calls IsSystemMoniker here*/
if
(
bctx
)
{
RegisterBindStatusCallback
(
bctx
,
&
bscallback
->
IBindStatusCallback_iface
,
NULL
,
0
);
IBindCtx_AddRef
(
bctx
);
hres
=
RegisterBindStatusCallback
(
bctx
,
&
bscallback
->
IBindStatusCallback_iface
,
NULL
,
0
);
if
(
SUCCEEDED
(
hres
))
IBindCtx_AddRef
(
bctx
);
}
else
{
hres
=
CreateAsyncBindCtx
(
0
,
&
bscallback
->
IBindStatusCallback_iface
,
NULL
,
&
bctx
);
if
(
FAILED
(
hres
))
{
WARN
(
"CreateAsyncBindCtx failed: %08x
\n
"
,
hres
);
bscallback
->
vtbl
->
stop_binding
(
bscallback
,
hres
);
return
hres
;
}
}
if
(
FAILED
(
hres
))
{
bscallback
->
vtbl
->
stop_binding
(
bscallback
,
hres
)
;
return
hres
;
}
hres
=
IMoniker_BindToStorage
(
bscallback
->
mon
,
bctx
,
NULL
,
&
IID_IStream
,
(
void
**
)
&
str
);
...
...
@@ -1473,7 +1474,6 @@ static void handle_navigation_error(nsChannelBSC *This, DWORD result)
return
;
if
(
!
doc
->
client_cmdtrg
)
if
(
FAILED
(
hres
))
return
;
bound
.
lLbound
=
0
;
...
...
dlls/mshtml/nsembed.c
View file @
df53b501
...
...
@@ -280,6 +280,7 @@ static nsresult NSAPI nsDirectoryServiceProvider2_GetFile(nsIDirectoryServicePro
return
nsres
;
}
assert
(
profile_directory
!=
NULL
);
return
nsIFile_Clone
(
profile_directory
,
_retval
);
}
...
...
dlls/mshtml/nsio.c
View file @
df53b501
...
...
@@ -1042,10 +1042,16 @@ static nsresult NSAPI nsChannel_AsyncOpen(nsIHttpChannel *iface, nsIStreamListen
return
NS_ERROR_FAILURE
;
if
(
TRACE_ON
(
mshtml
))
{
HRESULT
hres
;
BSTR
uri_str
;
IUri_GetDisplayUri
(
This
->
uri
->
uri
,
&
uri_str
);
TRACE
(
"opening %s
\n
"
,
debugstr_w
(
uri_str
));
SysFreeString
(
uri_str
);
hres
=
IUri_GetDisplayUri
(
This
->
uri
->
uri
,
&
uri_str
);
if
(
SUCCEEDED
(
hres
))
{
TRACE
(
"opening %s
\n
"
,
debugstr_w
(
uri_str
));
SysFreeString
(
uri_str
);
}
else
{
WARN
(
"GetDisplayUri failed: %08x
\n
"
,
hres
);
}
}
if
(
This
->
uri
->
is_doc_uri
)
{
...
...
dlls/mshtml/pluginhost.c
View file @
df53b501
...
...
@@ -1301,8 +1301,10 @@ static HRESULT WINAPI PHInPlaceSite_GetWindowContext(IOleInPlaceSiteEx *iface,
return
hres
;
hres
=
create_ip_window
(
ppDoc
);
if
(
FAILED
(
hres
))
if
(
FAILED
(
hres
))
{
IOleInPlaceFrame_Release
(
ip_frame
);
return
hres
;
}
*
ppFrame
=
ip_frame
;
*
lprcPosRect
=
This
->
rect
;
...
...
dlls/mshtml/protocol.c
View file @
df53b501
...
...
@@ -218,6 +218,7 @@ static HRESULT WINAPI AboutProtocol_Start(IInternetProtocol *iface, LPCWSTR szUr
LPCWSTR
text
=
NULL
;
DWORD
data_len
;
BYTE
*
data
;
HRESULT
hres
;
static
const
WCHAR
html_begin
[]
=
{
0xfeff
,
'<'
,
'H'
,
'T'
,
'M'
,
'L'
,
'>'
,
0
};
static
const
WCHAR
html_end
[]
=
{
'<'
,
'/'
,
'H'
,
'T'
,
'M'
,
'L'
,
'>'
,
0
};
...
...
@@ -237,7 +238,9 @@ static HRESULT WINAPI AboutProtocol_Start(IInternetProtocol *iface, LPCWSTR szUr
memset
(
&
bindinfo
,
0
,
sizeof
(
bindinfo
));
bindinfo
.
cbSize
=
sizeof
(
BINDINFO
);
IInternetBindInfo_GetBindInfo
(
pOIBindInfo
,
&
grfBINDF
,
&
bindinfo
);
hres
=
IInternetBindInfo_GetBindInfo
(
pOIBindInfo
,
&
grfBINDF
,
&
bindinfo
);
if
(
FAILED
(
hres
))
return
hres
;
ReleaseBindInfo
(
&
bindinfo
);
TRACE
(
"bindf %x
\n
"
,
grfBINDF
);
...
...
@@ -605,7 +608,9 @@ static HRESULT WINAPI ResProtocol_Start(IInternetProtocol *iface, LPCWSTR szUrl,
memset
(
&
bindinfo
,
0
,
sizeof
(
bindinfo
));
bindinfo
.
cbSize
=
sizeof
(
BINDINFO
);
IInternetBindInfo_GetBindInfo
(
pOIBindInfo
,
&
grfBINDF
,
&
bindinfo
);
hres
=
IInternetBindInfo_GetBindInfo
(
pOIBindInfo
,
&
grfBINDF
,
&
bindinfo
);
if
(
FAILED
(
hres
))
return
hres
;
ReleaseBindInfo
(
&
bindinfo
);
len
=
strlenW
(
szUrl
)
+
16
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment