Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
dfffe7b4
Commit
dfffe7b4
authored
Nov 02, 2023
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Nov 08, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
uxtheme: If the application class is already set then OpenThemeData() should fail.
Signed-off-by:
Dmitry Timoshkov
<
dmitry@baikal.ru
>
parent
87f1a380
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
8 deletions
+12
-8
msstyles.c
dlls/uxtheme/msstyles.c
+12
-6
system.c
dlls/uxtheme/tests/system.c
+0
-2
No files found.
dlls/uxtheme/msstyles.c
View file @
dfffe7b4
...
@@ -1076,9 +1076,12 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
...
@@ -1076,9 +1076,12 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
parse_app_class_name
(
buf
,
szAppName
,
szClassName
);
parse_app_class_name
(
buf
,
szAppName
,
szClassName
);
if
(
szAppName
[
0
])
if
(
szAppName
[
0
])
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
szAppName
,
szClassName
);
{
else
/* If the application class is already set then fail */
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
pszAppName
,
szClassName
);
if
(
pszAppName
)
return
NULL
;
pszAppName
=
szAppName
;
}
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
pszAppName
,
szClassName
);
/* Fall back to default class if the specified subclass is not found */
/* Fall back to default class if the specified subclass is not found */
if
(
!
cls
)
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
NULL
,
szClassName
);
if
(
!
cls
)
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
NULL
,
szClassName
);
...
@@ -1088,9 +1091,12 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
...
@@ -1088,9 +1091,12 @@ PTHEME_CLASS MSSTYLES_OpenThemeClass(LPCWSTR pszAppName, LPCWSTR pszClassList, U
if
(
!
cls
&&
*
start
)
{
if
(
!
cls
&&
*
start
)
{
parse_app_class_name
(
start
,
szAppName
,
szClassName
);
parse_app_class_name
(
start
,
szAppName
,
szClassName
);
if
(
szAppName
[
0
])
if
(
szAppName
[
0
])
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
szAppName
,
szClassName
);
{
else
/* If the application class is already set then fail */
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
pszAppName
,
szClassName
);
if
(
pszAppName
)
return
NULL
;
pszAppName
=
szAppName
;
}
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
pszAppName
,
szClassName
);
/* Fall back to default class if the specified subclass is not found */
/* Fall back to default class if the specified subclass is not found */
if
(
!
cls
)
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
NULL
,
szClassName
);
if
(
!
cls
)
cls
=
MSSTYLES_FindClass
(
tfActiveTheme
,
NULL
,
szClassName
);
...
...
dlls/uxtheme/tests/system.c
View file @
dfffe7b4
...
@@ -562,9 +562,7 @@ static void test_OpenThemeData(void)
...
@@ -562,9 +562,7 @@ static void test_OpenThemeData(void)
ok
(
hRes
==
S_OK
,
"Got unexpected hr %#lx.
\n
"
,
hRes
);
ok
(
hRes
==
S_OK
,
"Got unexpected hr %#lx.
\n
"
,
hRes
);
SetLastError
(
0xdeadbeef
);
SetLastError
(
0xdeadbeef
);
hTheme
=
OpenThemeData
(
hWnd
,
L"explorer::treeview"
);
hTheme
=
OpenThemeData
(
hWnd
,
L"explorer::treeview"
);
todo_wine
ok
(
!
hTheme
,
"OpenThemeData() should fail
\n
"
);
ok
(
!
hTheme
,
"OpenThemeData() should fail
\n
"
);
todo_wine
ok
(
GetLastError
()
==
E_PROP_ID_UNSUPPORTED
,
"Got unexpected %#lx.
\n
"
,
GetLastError
());
ok
(
GetLastError
()
==
E_PROP_ID_UNSUPPORTED
,
"Got unexpected %#lx.
\n
"
,
GetLastError
());
SetWindowTheme
(
hWnd
,
NULL
,
NULL
);
SetWindowTheme
(
hWnd
,
NULL
,
NULL
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment