Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
e0361765
Commit
e0361765
authored
Aug 01, 2016
by
Nikolay Sivov
Committed by
Alexandre Julliard
Aug 01, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32/listview: Remove redundant check in LVM_DELETECOLUMN handler.
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
5faab43d
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
2 deletions
+8
-2
listview.c
dlls/comctl32/listview.c
+2
-2
listview.c
dlls/comctl32/tests/listview.c
+6
-0
No files found.
dlls/comctl32/listview.c
View file @
e0361765
...
@@ -5621,8 +5621,8 @@ static BOOL LISTVIEW_DeleteColumn(LISTVIEW_INFO *infoPtr, INT nColumn)
...
@@ -5621,8 +5621,8 @@ static BOOL LISTVIEW_DeleteColumn(LISTVIEW_INFO *infoPtr, INT nColumn)
TRACE
(
"nColumn=%d
\n
"
,
nColumn
);
TRACE
(
"nColumn=%d
\n
"
,
nColumn
);
if
(
nColumn
<
0
||
DPA_GetPtrCount
(
infoPtr
->
hdpaColumns
)
==
0
if
(
nColumn
<
0
||
nColumn
>=
DPA_GetPtrCount
(
infoPtr
->
hdpaColumns
))
||
nColumn
>=
DPA_GetPtrCount
(
infoPtr
->
hdpaColumns
))
return
FALSE
;
return
FALSE
;
/* While the MSDN specifically says that column zero should not be deleted,
/* While the MSDN specifically says that column zero should not be deleted,
what actually happens is that the column itself is deleted but no items or subitems
what actually happens is that the column itself is deleted but no items or subitems
...
...
dlls/comctl32/tests/listview.c
View file @
e0361765
...
@@ -1420,6 +1420,12 @@ static void test_columns(void)
...
@@ -1420,6 +1420,12 @@ static void test_columns(void)
10
,
10
,
100
,
200
,
hwndparent
,
NULL
,
NULL
,
NULL
);
10
,
10
,
100
,
200
,
hwndparent
,
NULL
,
NULL
,
NULL
);
ok
(
hwnd
!=
NULL
,
"failed to create listview window
\n
"
);
ok
(
hwnd
!=
NULL
,
"failed to create listview window
\n
"
);
rc
=
SendMessageA
(
hwnd
,
LVM_DELETECOLUMN
,
-
1
,
0
);
ok
(
!
rc
,
"got %d
\n
"
,
rc
);
rc
=
SendMessageA
(
hwnd
,
LVM_DELETECOLUMN
,
0
,
0
);
ok
(
!
rc
,
"got %d
\n
"
,
rc
);
/* Add a column with no mask */
/* Add a column with no mask */
memset
(
&
column
,
0xcc
,
sizeof
(
column
));
memset
(
&
column
,
0xcc
,
sizeof
(
column
));
column
.
mask
=
0
;
column
.
mask
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment