vbscript/tests: Add missing checks for Close() calls (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

vbscript/tests: Add missing checks for Close() calls (Coverity).
e04c168c · Nikolay Sivov · Alexandre Julliard · ac72e61e · e04c168c
Commit e04c168c authored Jan 03, 2020 by Nikolay Sivov Committed by Alexandre Julliard Jan 03, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 7 deletions

run.c dlls/vbscript/tests/run.c +4 -7

No files found.
--- a/dlls/vbscript/tests/run.c
+++ b/dlls/vbscript/tests/run.c
@@ -1956,7 +1956,6 @@ static HRESULT parse_script(DWORD flags, BSTR script_str, const WCHAR *delim)
    IActiveScriptParse *parser;
    IActiveScript *engine;
    IDispatch *script_disp;
-    LONG ref;
    HRESULT hres;

    engine = create_and_init_script(flags, TRUE);
@@ -1980,13 +1979,10 @@ static HRESULT parse_script(DWORD flags, BSTR script_str, const WCHAR *delim)

    hres = IActiveScriptParse_ParseScriptText(parser, script_str, NULL, NULL, delim, 0, 0, 0, NULL, NULL);

-    IActiveScript_Close(engine);
-
    IDispatch_Release(script_disp);
-    IActiveScript_Release(engine);
+    IActiveScriptParse_Release(parser);
+    close_script(engine);

-    ref = IActiveScriptParse_Release(parser);
-    ok(!ref, "ref=%d\n", ref);
    return hres;
 }

@@ -2383,7 +2379,8 @@ static void test_gc(void)

    SET_EXPECT(global_success_d);
    SET_EXPECT(global_success_i);
-    IActiveScript_Close(engine);
+    hres = IActiveScript_Close(engine);
+    ok(hres == S_OK, "Close failed: %08x\n", hres);
    CHECK_CALLED(global_success_d);
    CHECK_CALLED(global_success_i);