Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
e1dd6a86
Commit
e1dd6a86
authored
Dec 22, 2009
by
Andrew Nguyen
Committed by
Alexandre Julliard
Dec 22, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dxdiagn: Fix a return value and avoid validating the input parameter for…
dxdiagn: Fix a return value and avoid validating the input parameter for IDxDiagProviderImpl::GetContainer.
parent
dddf714f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
6 deletions
+1
-6
provider.c
dlls/dxdiagn/provider.c
+1
-4
provider.c
dlls/dxdiagn/tests/provider.c
+0
-2
No files found.
dlls/dxdiagn/provider.c
View file @
e1dd6a86
...
...
@@ -110,11 +110,8 @@ static HRESULT WINAPI IDxDiagProviderImpl_GetRootContainer(PDXDIAGPROVIDER iface
IDxDiagProviderImpl
*
This
=
(
IDxDiagProviderImpl
*
)
iface
;
TRACE
(
"(%p,%p)
\n
"
,
iface
,
ppInstance
);
if
(
NULL
==
ppInstance
)
{
return
E_INVALIDARG
;
}
if
(
FALSE
==
This
->
init
)
{
return
E_INVALIDARG
;
/* should be E_CO_UNINITIALIZED */
return
CO_E_NOTINITIALIZED
;
}
if
(
NULL
==
This
->
pRootContainer
)
{
hr
=
DXDiag_CreateDXDiagContainer
(
&
IID_IDxDiagContainer
,
(
void
**
)
&
This
->
pRootContainer
);
...
...
dlls/dxdiagn/tests/provider.c
View file @
e1dd6a86
...
...
@@ -107,12 +107,10 @@ static void test_GetRootContainer(void)
/* Test calling IDxDiagProvider::GetRootContainer before initialization. */
hr
=
IDxDiagProvider_GetRootContainer
(
pddp
,
NULL
);
todo_wine
ok
(
hr
==
CO_E_NOTINITIALIZED
,
"Expected IDxDiagProvider::GetRootContainer to return CO_E_NOTINITIALIZED, got %x
\n
"
,
hr
);
hr
=
IDxDiagProvider_GetRootContainer
(
pddp
,
&
pddc
);
todo_wine
ok
(
hr
==
CO_E_NOTINITIALIZED
,
"Expected IDxDiagProvider::GetRootContainer to return CO_E_NOTINITIALIZED, got %x
\n
"
,
hr
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment