winemac: Make WineOpenGLContext hold a strong reference to its view.

Its superclass, NSOpenGLContext, only holds a weak reference. The view was sometimes being deallocated before the context was disposed of, resulting in crashes.

winemac: Make WineOpenGLContext hold a strong reference to its view.
e2119246 · Ken Thomases · Alexandre Julliard · 2963a2d4 · e2119246
Commit e2119246 authored Jan 14, 2014 by Ken Thomases Committed by Alexandre Julliard Jan 14, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 16 additions and 0 deletions

cocoa_opengl.m dlls/winemac.drv/cocoa_opengl.m +16 -0

No files found.
--- a/dlls/winemac.drv/cocoa_opengl.m
+++ b/dlls/winemac.drv/cocoa_opengl.m
@@ -35,10 +35,26 @@

    - (void) dealloc
    {
+        [[self view] release];
        [latentView release];
        [super dealloc];
    }

+    - (void) setView:(NSView*)newView
+    {
+        NSView* oldView = [self view];
+        [super setView:newView];
+        [newView retain];
+        [oldView release];
+    }
+
+    - (void) clearDrawable
+    {
+        NSView* oldView = [self view];
+        [super clearDrawable];
+        [oldView release];
+    }
+
    /* On at least some versions of Mac OS X, -[NSOpenGLContext clearDrawable] has the
       undesirable side effect of ordering the view's GL surface off-screen.  This isn't
       done when just changing the context's view to a different view (which I would