d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support().

There's no point in querying this multiple times, it's not going to change. Perhaps more importantly, calling is_warp_device() inside a todo_wine block will cause "Test succeeded inside todo block: ..." messages from get_device_adapter_desc(). These appear to have been introduced by commit fcc276ec. Arguably get_device_adapter_desc() shouldn't use ok() in the first place.

d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support().
e5f5bea3 · Henri Verbeet · Alexandre Julliard · 7d20333f · e5f5bea3
Commit e5f5bea3 authored Sep 14, 2022 by Henri Verbeet Committed by Alexandre Julliard Sep 15, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

d3d11.c dlls/d3d11/tests/d3d11.c +2 -1

No files found.
--- a/dlls/d3d11/tests/d3d11.c
+++ b/dlls/d3d11/tests/d3d11.c
@@ -20961,6 +20961,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma
        D3D_FEATURE_LEVEL feature_level, const struct format_support *formats,
        unsigned int format_count, unsigned int feature_flag, const char *feature_name)
 {
+    BOOL warp = is_warp_device(device);
    unsigned int i;

    for (i = 0; i < format_count; ++i)
@@ -20971,7 +20972,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma
        if (formats[i].fl_required <= feature_level)
        {
            todo_wine_if (feature_flag == D3D11_FORMAT_SUPPORT_DISPLAY)
-                ok(supported || broken(is_warp_device(device)),
+                ok(supported || broken(warp),
                        "Format %#x - %s not supported, format support %#x.\n",
                        format, feature_name, format_support[format]);
            continue;