Added pointer validation and additional sanity check to IsValidSid().

e6bffc09 · Ian Schmidt · Alexandre Julliard · b49b4117 · e6bffc09
Commit e6bffc09 authored Jul 18, 1999 by Ian Schmidt Committed by Alexandre Julliard Jul 18, 1999
Show whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

security.c dlls/advapi32/security.c +9 -0

No files found.
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -202,6 +202,15 @@ CopySid( DWORD nDestinationSidLength, PSID pDestinationSid, PSID pSourceSid )
 BOOL WINAPI
 IsValidSid( PSID pSid )
 {
+    if (IsBadReadPtr(pSid, 4))
+    {
+        WARN_(security)("(%p): invalid pointer!", pSid);
+        return FALSE;
+    }
+
+    if (pSid->SubAuthorityCount > SID_MAX_SUB_AUTHORITIES)
+        return FALSE;
+
    if (!pSid || pSid->Revision != SID_REVISION)
        return FALSE;