shell32: Fix a use after free (Coverity).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

shell32: Fix a use after free (Coverity).
e6ce281d · Sven Baars · Alexandre Julliard · 097733fe · e6ce281d
Commit e6ce281d authored May 28, 2019 by Sven Baars Committed by Alexandre Julliard May 29, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

shellitem.c dlls/shell32/shellitem.c +3 -1

No files found.
--- a/dlls/shell32/shellitem.c
+++ b/dlls/shell32/shellitem.c
@@ -1289,9 +1289,11 @@ HRESULT WINAPI SHCreateShellItemArray(PCIDLIST_ABSOLUTE pidlParent,
    if(SUCCEEDED(ret))
    {
        ret = create_shellitemarray(array, cidl, ppsiItemArray);
-        heap_free(array);
        if(SUCCEEDED(ret))
+        {
+            heap_free(array);
            return ret;
+        }
    }

    /* Something failed, clean up. */