winedump: Be stricter about sizes while walking module's list.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

winedump: Be stricter about sizes while walking module's list.
e8777691 · Eric Pouech · Alexandre Julliard · cda616d8 · e8777691
Commit e8777691 authored Feb 01, 2023 by Eric Pouech Committed by Alexandre Julliard Feb 02, 2023
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

pdb.c tools/winedump/pdb.c +3 -0

No files found.
--- a/tools/winedump/pdb.c
+++ b/tools/winedump/pdb.c
@@ -637,6 +637,9 @@ static void pdb_dump_symbols(struct pdb_reader* reader, PDB_STREAM_INDEXES* sidx
    /* Read per-module symbol / linenumber tables */
    file = (const char*)symbols + sizeof(PDB_SYMBOLS);
    while (file - (const char*)symbols < sizeof(PDB_SYMBOLS) + symbols->module_size)
+    while ((file - (const char*)symbols + sizeof(symbols->version) < sizeof(PDB_SYMBOLS) + symbols->module_size) &&
+           (file - (const char*)symbols +
+            symbols->version < 19970000 ? sizeof(PDB_SYMBOL_FILE) : sizeof(PDB_SYMBOL_FILE_EX)) < sizeof(PDB_SYMBOLS) + symbols->module_size)
    {
        int stream_nr, symbol_size, lineno_size, lineno2_size;
        const char* file_name;