Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
e88b09a3
Commit
e88b09a3
authored
Oct 07, 2008
by
James Hawkins
Committed by
Alexandre Julliard
Oct 07, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Don't update the table columns if there are no more columns.
This should fix the heap corruption that caused intermittent crashes for patchwatcher.
parent
7cd67368
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
1 deletion
+5
-1
table.c
dlls/msi/table.c
+5
-1
No files found.
dlls/msi/table.c
View file @
e88b09a3
...
...
@@ -585,6 +585,8 @@ static UINT table_get_column_info( MSIDATABASE *db, LPCWSTR name, MSICOLUMNINFO
if
(
r
!=
ERROR_SUCCESS
)
return
r
;
*
pcount
=
column_count
;
/* if there's no columns, there's no table */
if
(
column_count
==
0
)
return
ERROR_INVALID_PARAMETER
;
...
...
@@ -603,7 +605,6 @@ static UINT table_get_column_info( MSIDATABASE *db, LPCWSTR name, MSICOLUMNINFO
}
*
pcols
=
columns
;
*
pcount
=
column_count
;
return
r
;
}
...
...
@@ -1034,6 +1035,9 @@ static void msi_update_table_columns( MSIDATABASE *db, LPCWSTR name )
msi_free
(
table
->
colinfo
);
table_get_column_info
(
db
,
name
,
&
table
->
colinfo
,
&
table
->
col_count
);
if
(
!
table
->
col_count
)
return
;
size
=
msi_table_get_row_size
(
db
,
table
->
colinfo
,
table
->
col_count
);
offset
=
table
->
colinfo
[
table
->
col_count
-
1
].
offset
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment