Authors: Chris Morgan <cmorgan@wpi.edu>, James Abbatiello <abbeyj@wpi.edu>

Fixed LISTVIEW_GetItemChanges() to perform a more complete comparison between lpItem and lpLVItem. Now compares the pszText string of the lpItem and lpLVItem structs. Fixes a bug where the old and new item have the same attributes but their text differs and GetItemChanges() compares them as equal.

Authors: Chris Morgan <cmorgan@wpi.edu>, James Abbatiello <abbeyj@wpi.edu>
eab73f89 · Alexandre Julliard · 93c68a7e · eab73f89
Commit eab73f89 authored May 01, 1999 by Alexandre Julliard
Hide whitespace changes
Inline Side-by-side

Showing with 24 additions and 1 deletion

listview.c dlls/comctl32/listview.c +24 -1

No files found.
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -1205,10 +1205,33 @@ static UINT LISTVIEW_GetItemChanges(LISTVIEW_ITEM *lpItem, LPLVITEMA lpLVItem)
        {
          uChanged |= LVIF_TEXT; 
        }
+	else
+	{
+	  if (lpLVItem->pszText)
+	  {
+	    if (lpItem->pszText)
+	    {
+	      if (strcmp(lpLVItem->pszText, lpItem->pszText) != 0)
+	      {
+		uChanged |= LVIF_TEXT;
+	      }
+	    }
+	    else
+	    {
+	      uChanged |= LVIF_TEXT;
+	    }
+	  }
+	  else
+	  {
+	    if (lpItem->pszText)
+	    {
+	      uChanged |= LVIF_TEXT;
+	    }
+	  }
+	}
      }
    }
  }
-
  return uChanged;
 }