Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
eb2aae66
Commit
eb2aae66
authored
Aug 21, 2010
by
Nikolay Sivov
Committed by
Alexandre Julliard
Aug 23, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comctl32/imagelist: Make IImageList_Merge() crash like it does on native.
parent
84a65982
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
imagelist.c
dlls/comctl32/imagelist.c
+2
-3
imagelist.c
dlls/comctl32/tests/imagelist.c
+7
-0
No files found.
dlls/comctl32/imagelist.c
View file @
eb2aae66
...
...
@@ -3365,15 +3365,14 @@ static HRESULT WINAPI ImageListImpl_Copy(IImageList *iface, int iDst,
}
static
HRESULT
WINAPI
ImageListImpl_Merge
(
IImageList
*
iface
,
int
i1
,
IUnknown
*
punk2
,
int
i2
,
int
dx
,
int
dy
,
REFIID
riid
,
PVOID
*
ppv
)
IUnknown
*
punk2
,
int
i2
,
int
dx
,
int
dy
,
REFIID
riid
,
void
*
*
ppv
)
{
HIMAGELIST
This
=
(
HIMAGELIST
)
iface
;
IImageList
*
iml2
=
NULL
;
HIMAGELIST
hNew
;
HRESULT
ret
=
E_FAIL
;
if
(
!
punk2
||
!
ppv
)
return
E_FAIL
;
TRACE
(
"(%p)->(%d %p %d %d %d %s %p)
\n
"
,
iface
,
i1
,
punk2
,
i2
,
dx
,
dy
,
debugstr_guid
(
riid
),
ppv
);
/* TODO: Add test for IID_ImageList2 too */
if
(
FAILED
(
IImageList_QueryInterface
(
punk2
,
&
IID_IImageList
,
...
...
dlls/comctl32/tests/imagelist.c
View file @
eb2aae66
...
...
@@ -1674,6 +1674,13 @@ static void test_IImageList_Merge(void)
ret
=
-
1
;
ok
(
IImageList_ReplaceIcon
(
imgl2
,
-
1
,
hicon1
,
&
ret
)
==
S_OK
&&
(
ret
==
0
),
"add icon1 to himl2 failed
\n
"
);
if
(
0
)
{
/* null cases that crash on native */
hr
=
IImageList_Merge
(
imgl1
,
-
1
,
NULL
,
0
,
0
,
0
,
&
IID_IImageList
,
(
void
**
)
&
merge
);
hr
=
IImageList_Merge
(
imgl1
,
-
1
,
(
IUnknown
*
)
imgl2
,
0
,
0
,
0
,
&
IID_IImageList
,
NULL
);
}
/* If himl1 has no images, merge still succeeds */
hr
=
IImageList_Merge
(
imgl1
,
-
1
,
(
IUnknown
*
)
imgl2
,
0
,
0
,
0
,
&
IID_IImageList
,
(
void
**
)
&
merge
);
ok
(
hr
==
S_OK
,
"merge himl1,-1 failed
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment