winegstreamer: Leave media source critical section before unlocking workqueue.

Today, if media_source_Shutdown is called around the same time as a work item is put on the async_commands_queue, we end up in a deadlock if Shutdown enters media source's cs first, as it waits for the queue's callback to finish, which, in turn, waits for the object's cs to be released. To avoid this leave the cs, before unlocking the workqueue, to let any callback on the queue finish running. Signed-off-by: Bernhard Kölbl <bkoelbl@codeweavers.com>

winegstreamer: Leave media source critical section before unlocking workqueue.
ef1b9648 · Bernhard Kölbl · Alexandre Julliard · 35cff9ec · ef1b9648
Commit ef1b9648 authored Aug 02, 2023 by Bernhard Kölbl Committed by Alexandre Julliard Aug 03, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

media_source.c dlls/winegstreamer/media_source.c +2 -2

No files found.
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -1570,10 +1570,10 @@ static HRESULT WINAPI media_source_Shutdown(IMFMediaSource *iface)
    free(source->descriptors);
    free(source->streams);

-    MFUnlockWorkQueue(source->async_commands_queue);
-
    LeaveCriticalSection(&source->cs);

+    MFUnlockWorkQueue(source->async_commands_queue);
+
    return S_OK;
 }