msi: Don't remove a file if the old file is strictly newer than the version to be installed.

f33ef6ac · James Hawkins · Alexandre Julliard · ca4b17ef · f33ef6ac
Commit f33ef6ac authored Aug 18, 2008 by James Hawkins Committed by Alexandre Julliard Aug 19, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

files.c dlls/msi/files.c +3 -3

No files found.
--- a/dlls/msi/files.c
+++ b/dlls/msi/files.c
@@ -453,10 +453,10 @@ UINT ACTION_RemoveFiles( MSIPACKAGE *package )
        if ( file->state != msifs_present )
            continue;

-        /* only remove a file if the version to be installed
-         * is strictly newer than the old file
+        /* don't remove a file if the old file
+         * is strictly newer than the version to be installed
         */
-        if ( msi_compare_file_version( file ) >= 0 )
+        if ( msi_compare_file_version( file ) < 0 )
            continue;

        TRACE("removing %s\n", debugstr_w(file->File) );