Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
f378394a
Commit
f378394a
authored
Nov 19, 2009
by
Juan Lang
Committed by
Alexandre Julliard
Nov 20, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
crypt32: Correct CertIsValidCRLForCertificate for certificates that do not…
crypt32: Correct CertIsValidCRLForCertificate for certificates that do not contain a CRL dist points extension.
parent
bcbfddd8
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
10 deletions
+6
-10
crl.c
dlls/crypt32/crl.c
+4
-8
crl.c
dlls/crypt32/tests/crl.c
+2
-2
No files found.
dlls/crypt32/crl.c
View file @
f378394a
...
...
@@ -649,15 +649,11 @@ BOOL WINAPI CertIsValidCRLForCertificate(PCCERT_CONTEXT pCert,
}
else
{
/* no CRL dist points extension in cert, c
ompare CRL's issuer
*
to cert's issuer.
/* no CRL dist points extension in cert, c
an't match the CRL
*
(which has an issuing dist point extension)
*/
if
(
!
CertCompareCertificateName
(
pCrl
->
dwCertEncodingType
,
&
pCrl
->
pCrlInfo
->
Issuer
,
&
pCert
->
pCertInfo
->
Issuer
))
{
ret
=
FALSE
;
SetLastError
(
CRYPT_E_NO_MATCH
);
}
ret
=
FALSE
;
SetLastError
(
CRYPT_E_NO_MATCH
);
}
LocalFree
(
idp
);
}
...
...
dlls/crypt32/tests/crl.c
View file @
f378394a
...
...
@@ -530,6 +530,7 @@ static void testFindCRL(void)
* match cert's issuer, but verisignCRL does not, so the expected count
* is 0.
*/
todo_wine
{
ok
(
count
==
3
||
broken
(
count
==
0
/* NT4, Win9x */
),
"expected 3 matching CRLs, got %d
\n
"
,
count
);
/* Only v1CRLWithIssuerAndEntry and v2CRLWithIssuingDistPoint contain
...
...
@@ -537,6 +538,7 @@ static void testFindCRL(void)
*/
ok
(
revoked_count
==
2
||
broken
(
revoked_count
==
0
/* NT4, Win9x */
),
"expected 2 matching CRL entries, got %d
\n
"
,
revoked_count
);
}
CertFreeCertificateContext
(
cert
);
...
...
@@ -1000,11 +1002,9 @@ static void testIsValidCRLForCert(void)
sizeof
(
v2CRLWithIssuingDistPoint
));
ok
(
crl
!=
NULL
,
"CertCreateCRLContext failed: %08x
\n
"
,
GetLastError
());
todo_wine
{
ret
=
pCertIsValidCRLForCertificate
(
cert1
,
crl
,
0
,
NULL
);
ok
(
!
ret
&&
GetLastError
()
==
CRYPT_E_NO_MATCH
,
"expected CRYPT_E_NO_MATCH, got %08x
\n
"
,
GetLastError
());
}
ret
=
pCertIsValidCRLForCertificate
(
cert2
,
crl
,
0
,
NULL
);
ok
(
!
ret
&&
GetLastError
()
==
CRYPT_E_NO_MATCH
,
"expected CRYPT_E_NO_MATCH, got %08x
\n
"
,
GetLastError
());
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment