Skip to content

W
wine-winehq
Commit f4558c64 authored by Detlef Riekenberg's avatar Detlef Riekenberg Committed by Alexandre Julliard
Browse files
Options

msxml3: Remove redundant NULL check before SysFreeString.

parent 410302d8
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 6 deletions
dlls/msxml3/saxreader.c
View file @ f4558c64
...@@ -1517,10 +1517,8 @@ static ULONG WINAPI isaxlocator_Release( ...@@ -1517,10 +1517,8 @@ static ULONG WINAPI isaxlocator_Release(
ref = InterlockedDecrement( &This->ref ); ref = InterlockedDecrement( &This->ref );
if ( ref == 0 ) if ( ref == 0 )
{ {
if(This->publicId) SysFreeString(This->publicId);
SysFreeString(This->publicId); SysFreeString(This->systemId);
if(This->systemId)
SysFreeString(This->systemId);
HeapFree(GetProcessHeap(), 0, This->nsStack); HeapFree(GetProcessHeap(), 0, This->nsStack);
ISAXXMLReader_Release((ISAXXMLReader*)&This->saxreader->lpSAXXMLReaderVtbl); ISAXXMLReader_Release((ISAXXMLReader*)&This->saxreader->lpSAXXMLReaderVtbl);
...@@ -1558,7 +1556,7 @@ static HRESULT WINAPI isaxlocator_getPublicId( ...@@ -1558,7 +1556,7 @@ static HRESULT WINAPI isaxlocator_getPublicId(
BSTR publicId; BSTR publicId;
saxlocator *This = impl_from_ISAXLocator( iface ); saxlocator *This = impl_from_ISAXLocator( iface );
if(This->publicId) SysFreeString(This->publicId); SysFreeString(This->publicId);
publicId = bstr_from_xmlChar(xmlSAX2GetPublicId(This->pParserCtxt)); publicId = bstr_from_xmlChar(xmlSAX2GetPublicId(This->pParserCtxt));
if(SysStringLen(publicId)) if(SysStringLen(publicId))
...@@ -1580,7 +1578,7 @@ static HRESULT WINAPI isaxlocator_getSystemId( ...@@ -1580,7 +1578,7 @@ static HRESULT WINAPI isaxlocator_getSystemId(
BSTR systemId; BSTR systemId;
saxlocator *This = impl_from_ISAXLocator( iface ); saxlocator *This = impl_from_ISAXLocator( iface );
if(This->systemId) SysFreeString(This->systemId); SysFreeString(This->systemId);
systemId = bstr_from_xmlChar(xmlSAX2GetSystemId(This->pParserCtxt)); systemId = bstr_from_xmlChar(xmlSAX2GetSystemId(This->pParserCtxt));
if(SysStringLen(systemId)) if(SysStringLen(systemId))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment