Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
f51e7900
Commit
f51e7900
authored
Oct 15, 2015
by
Nikolay Sivov
Committed by
Alexandre Julliard
Oct 15, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shlwapi: Fix SHPropertyBag_ReadLONG prototype (PVS-Studio).
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
5853e776
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
8 deletions
+6
-8
ordinal.c
dlls/shlwapi/ordinal.c
+2
-2
ordinal.c
dlls/shlwapi/tests/ordinal.c
+4
-6
No files found.
dlls/shlwapi/ordinal.c
View file @
f51e7900
...
...
@@ -5187,9 +5187,9 @@ HRESULT WINAPI IUnknown_QueryServiceForWebBrowserApp(IUnknown* lpUnknown,
* pValue: address to receive the property value as a 32-bit signed integer
*
* RETURNS
*
0 for Succes
s
*
HRESULT code
s
*/
BOOL
WINAPI
SHPropertyBag_ReadLONG
(
IPropertyBag
*
ppb
,
LPCWSTR
pszPropName
,
LPLONG
pValue
)
HRESULT
WINAPI
SHPropertyBag_ReadLONG
(
IPropertyBag
*
ppb
,
LPCWSTR
pszPropName
,
LPLONG
pValue
)
{
VARIANT
var
;
HRESULT
hr
;
...
...
dlls/shlwapi/tests/ordinal.c
View file @
f51e7900
...
...
@@ -1633,21 +1633,19 @@ static void test_SHPropertyBag_ReadLONG(void)
out
=
0xfeedface
;
rc
=
pSHPropertyBag_ReadLONG
(
NULL
,
szName1
,
&
out
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
0
),
"incorrect return %x
\n
"
,
rc
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
S_OK
),
"incorrect return %x
\n
"
,
rc
);
ok
(
out
==
0xfeedface
,
"value should not have changed
\n
"
);
rc
=
pSHPropertyBag_ReadLONG
(
&
pb
->
IPropertyBag_iface
,
NULL
,
&
out
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
0
)
||
broken
(
rc
==
1
),
"incorrect return %x
\n
"
,
rc
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
S_OK
)
||
broken
(
rc
==
S_FALSE
),
"incorrect return %x
\n
"
,
rc
);
ok
(
out
==
0xfeedface
,
"value should not have changed
\n
"
);
rc
=
pSHPropertyBag_ReadLONG
(
&
pb
->
IPropertyBag_iface
,
szName1
,
NULL
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
0
)
||
broken
(
rc
==
1
),
"incorrect return %x
\n
"
,
rc
);
ok
(
rc
==
E_INVALIDARG
||
broken
(
rc
==
S_OK
)
||
broken
(
rc
==
S_FALSE
),
"incorrect return %x
\n
"
,
rc
);
rc
=
pSHPropertyBag_ReadLONG
(
&
pb
->
IPropertyBag_iface
,
szName1
,
&
out
);
ok
(
rc
==
DISP_E_BADVARTYPE
||
broken
(
rc
==
0
)
||
broken
(
rc
==
1
),
"incorrect return %x
\n
"
,
rc
);
ok
(
rc
==
DISP_E_BADVARTYPE
||
broken
(
rc
==
S_OK
)
||
broken
(
rc
==
S_FALSE
),
"incorrect return %x
\n
"
,
rc
);
ok
(
out
==
0xfeedface
||
broken
(
out
==
0xfeedfa00
),
"value should not have changed %x
\n
"
,
out
);
IUnknown_Release
((
IUnknown
*
)
pb
);
}
static
void
test_SHSetWindowBits
(
void
)
{
HWND
hwnd
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment