msi: Don't leak memory on failure.

Signed-off-by: Pierre Schweitzer <pierre@reactos.org> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Don't leak memory on failure.
f621f410 · Pierre Schweitzer · Alexandre Julliard · 808f3158 · f621f410
Commit f621f410 authored Oct 21, 2017 by Pierre Schweitzer Committed by Alexandre Julliard Oct 23, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

action.c dlls/msi/action.c +5 -1

No files found.
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -195,7 +195,11 @@ static void ui_actioninfo(MSIPACKAGE *package, LPCWSTR action, BOOL start,
    template = msi_get_error_message(package->db, start ? MSIERR_INFO_ACTIONSTART : MSIERR_INFO_ACTIONENDED);

    row = MSI_CreateRecord(2);
-    if (!row) return;
+    if (!row)
+    {
+        msi_free(template);
+        return;
+    }
    MSI_RecordSetStringW(row, 0, template);
    MSI_RecordSetStringW(row, 1, action);
    MSI_RecordSetInteger(row, 2, start ? package->LastActionResult : rc);