Commit f65fd26f authored by Nikolay Sivov's avatar Nikolay Sivov Committed by Alexandre Julliard

msxml3: IXMLDOMAttribute shouldn't report its parent.

parent 535afbd3
......@@ -213,7 +213,10 @@ static HRESULT WINAPI domattr_get_parentNode(
IXMLDOMNode** parent )
{
domattr *This = impl_from_IXMLDOMAttribute( iface );
return IXMLDOMNode_get_parentNode( IXMLDOMNode_from_impl(&This->node), parent );
TRACE("(%p)->(%p)\n", This, parent);
if (!parent) return E_INVALIDARG;
*parent = NULL;
return S_FALSE;
}
static HRESULT WINAPI domattr_get_childNodes(
......
......@@ -1216,8 +1216,19 @@ static void test_domnode( void )
r = IXMLDOMElement_getAttributeNode( element, str, &attr);
ok( r == S_OK, "GetAttributeNode ret %08x\n", r );
ok( attr != NULL, "getAttributeNode returned NULL\n" );
if(attr)
if (attr)
{
r = IXMLDOMAttribute_get_parentNode( attr, NULL );
ok( r == E_INVALIDARG, "Expected E_INVALIDARG, ret %08x\n", r );
/* attribute doesn't have a parent in msxml interpretation */
node = (IXMLDOMNode*)0xdeadbeef;
r = IXMLDOMAttribute_get_parentNode( attr, &node );
ok( r == S_FALSE, "Expected S_FALSE, ret %08x\n", r );
ok( node == NULL, "Expected NULL, got %p\n", node );
IXMLDOMAttribute_Release(attr);
}
SysFreeString( str );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment