msxml3: Fixed attribute value string leak (Valgrind).

f9df8845 · Nikolay Sivov · Alexandre Julliard · e2bf5163 · f9df8845
Commit f9df8845 authored Apr 26, 2014 by Nikolay Sivov Committed by Alexandre Julliard Apr 28, 2014
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

element.c dlls/msxml3/element.c +5 -1

No files found.
--- a/dlls/msxml3/element.c
+++ b/dlls/msxml3/element.c
@@ -1284,7 +1284,11 @@ static HRESULT WINAPI domelem_setAttribute(
        xmlFree(local);

        if (ns)
-            return xmlStrEqual(ns->href, xml_value) ? S_OK : E_INVALIDARG;
+        {
+            int cmp = xmlStrEqual(ns->href, xml_value);
+            heap_free(xml_value);
+            return cmp ? S_OK : E_INVALIDARG;
+        }
    }

    if (!xmlSetNsProp(element, NULL, xml_name, xml_value))