winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.

The GdiConvertToDevmodeW call can crash if the incoming DEVMODEA has nonsense values.

winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.
faae2144 · Tim Clem · Alexandre Julliard · 796f2822 · faae2144
Commit faae2144 authored Nov 14, 2022 by Tim Clem Committed by Alexandre Julliard Nov 15, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

info.c dlls/winspool.drv/info.c +1 -1

No files found.
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -1898,7 +1898,7 @@ LONG WINAPI DocumentPropertiesA(HWND hwnd, HANDLE printer, char *device_name, DE
        outputW = malloc(ret);
    }

-    if (input) inputW = GdiConvertToDevmodeW(input);
+    if (input && (mode & DM_IN_BUFFER)) inputW = GdiConvertToDevmodeW(input);

    ret = DocumentPropertiesW(hwnd, printer, device, outputW, inputW, mode);