scrobj: Fix some leaks on error paths (Coverity).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

scrobj: Fix some leaks on error paths (Coverity).
fae51bd7 · Sven Baars · Alexandre Julliard · a0c6c8c2 · fae51bd7
Commit fae51bd7 authored Oct 21, 2019 by Sven Baars Committed by Alexandre Julliard Oct 21, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

scrobj.c dlls/scrobj/scrobj.c +3 -2

No files found.
--- a/dlls/scrobj/scrobj.c
+++ b/dlls/scrobj/scrobj.c
@@ -1491,6 +1491,7 @@ static HRESULT parse_scriptlet_public(struct scriptlet_factory *factory)
            if (!wcsicmp(member_iter->name, member->name))
            {
                FIXME("Duplicated member %s\n", debugstr_w(member->name));
+                heap_free(member);
                return E_FAIL;
            }
        }
@@ -1529,11 +1530,11 @@ static HRESULT parse_scriptlet_public(struct scriptlet_factory *factory)
                    return E_FAIL;
                }

-                if (!(parameter = heap_alloc(sizeof(*parameter)))) return E_OUTOFMEMORY;
+                if (!(parameter = heap_alloc_zero(sizeof(*parameter)))) return E_OUTOFMEMORY;
+                list_add_tail(&member->u.parameters, &parameter->entry);

                hres = read_xml_value(factory, &parameter->name);
                if (FAILED(hres)) return hres;
-                list_add_tail(&member->u.parameters, &parameter->entry);
                if (!empty && FAILED(hres = expect_end_element(factory))) return hres;
            }
            break;