Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
fc78f552
Commit
fc78f552
authored
Mar 26, 2009
by
Huw Davies
Committed by
Alexandre Julliard
Mar 30, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32: AddRef does not return an HRESULT. Have the constructor create the object…
ole32: AddRef does not return an HRESULT. Have the constructor create the object with one reference.
parent
25f1b058
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
14 deletions
+2
-14
clipboard.c
dlls/ole32/clipboard.c
+2
-14
No files found.
dlls/ole32/clipboard.c
View file @
fc78f552
...
...
@@ -322,13 +322,8 @@ static HRESULT WINAPI OLEClipbrd_IEnumFORMATETC_Clone
return
E_INVALIDARG
;
hr
=
enum_fmtetc_construct
(
This
->
countFmt
,
This
->
pFmt
,
ppenum
);
if
(
FAILED
(
hr
))
return
hr
;
/* FIXME: This is wrong! */
if
(
FAILED
(
hr
=
IEnumFORMATETC_AddRef
(
*
ppenum
)))
return
(
hr
);
return
(
*
ppenum
)
?
S_OK
:
E_OUTOFMEMORY
;
return
hr
;
}
static
const
IEnumFORMATETCVtbl
efvt
=
...
...
@@ -347,7 +342,6 @@ static const IEnumFORMATETCVtbl efvt =
*
* Creates an IEnumFORMATETC enumerator from an array of FORMATETC
* Structures.
* NOTE: this does not AddRef the interface.
*/
static
HRESULT
enum_fmtetc_construct
(
UINT
cfmt
,
const
FORMATETC
afmt
[],
IEnumFORMATETC
**
obj
)
{
...
...
@@ -358,7 +352,7 @@ static HRESULT enum_fmtetc_construct(UINT cfmt, const FORMATETC afmt[], IEnumFOR
ef
=
HeapAlloc
(
GetProcessHeap
(),
0
,
sizeof
(
*
ef
));
if
(
!
ef
)
return
E_OUTOFMEMORY
;
ef
->
ref
=
0
;
ef
->
ref
=
1
;
ef
->
lpVtbl
=
&
efvt
;
ef
->
pos
=
0
;
...
...
@@ -1046,12 +1040,6 @@ static HRESULT WINAPI OLEClipbrd_IDataObject_EnumFormatEtc(
if
(
FAILED
(
hr
))
HANDLE_ERROR
(
hr
);
/* FIXME: This is wrong! */
if
(
FAILED
(
hr
=
IEnumFORMATETC_AddRef
(
*
ppenumFormatEtc
)))
HANDLE_ERROR
(
hr
);
hr
=
S_OK
;
CLEANUP:
/*
* Free the array of FORMATETC's
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment