msi: Fix a leak on error path (Coverity).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Fix a leak on error path (Coverity).
fe91ae51 · Sven Baars · Alexandre Julliard · d2f3fc03 · fe91ae51
Commit fe91ae51 authored Sep 26, 2019 by Sven Baars Committed by Alexandre Julliard Sep 26, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

dialog.c dlls/msi/dialog.c +5 -1

No files found.
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -4033,7 +4033,11 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di
    msiobj_release( &rec->hdr );

    rec = MSI_CreateRecord(2);
-    if (!rec) return NULL;
+    if (!rec)
+    {
+        msi_dialog_destroy(dialog);
+        return NULL;
+    }
    MSI_RecordSetStringW(rec, 1, name);
    MSI_RecordSetStringW(rec, 2, szDialogCreated);
    MSI_ProcessMessage(package, INSTALLMESSAGE_ACTIONSTART, rec);