• Jinoh Kang's avatar
    ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher. · 057467bf
    Jinoh Kang authored
    Today, NtContinue() on ARM64 does not restore X16 and X17 from the
    context.
    
    This is because the values for X16 and X17 are overwritten when the
    current thread returns to the "user mode" (PE side) via
    __wine_syscall_dispatcher, which in turn uses them as scratch registers
    for restoring SP and PC respectively.
    
    We cannot avoid using scratch registers when restoring SP and PC.  This
    is because ARMv8 does not have an unprivileged (EL0) instruction that
    loads SP and PC from memory or non-GPR architectural state.
    
    Fix this by making ARM64 __wine_syscall_dispatcher perform a full
    context restore via raise(SIGUSR2) when NtContinue() is used.
    
    Since raising a signal is quite expensive, it should be done only when
    necessary. To achieve this, split the ARM64 syscall dispatcher's
    returning behaviour into a fast path (that does not involve signals) and
    a slow path (that involves signals):
    
    - If CONTEXT_INTEGER is not set, the dispatcher takes the fast path:
      the X16 and X17 registers are clobbered as usual.
    
    - If X16 == PC and X17 == SP, the dispatcher also takes the fast path:
      it can safely use X16 and X17 without corrupting the register values,
      since those two registers already have the desired values.
    
      This fast path is used in call_user_apc_dispatcher(),
      call_user_exception_dispatcher(), and call_init_thunk().
    
    - Otherwise, the dispatcher takes the slow path: it raises SIGUSR2 and
      does full context restore in the signal handler.
    
    Fixes: 88e33621
    057467bf
Name
Last commit
Last update
dlls Loading commit data...
documentation Loading commit data...
fonts Loading commit data...
include Loading commit data...
libs Loading commit data...
loader Loading commit data...
nls Loading commit data...
po Loading commit data...
programs Loading commit data...
server Loading commit data...
tools Loading commit data...
.editorconfig Loading commit data...
.gitlab-ci.yml Loading commit data...
.mailmap Loading commit data...
ANNOUNCE Loading commit data...
AUTHORS Loading commit data...
COPYING.LIB Loading commit data...
LICENSE Loading commit data...
LICENSE.OLD Loading commit data...
MAINTAINERS Loading commit data...
README Loading commit data...
VERSION Loading commit data...
aclocal.m4 Loading commit data...
configure Loading commit data...
configure.ac Loading commit data...