• Kevin Puetz's avatar
    oleaut32/tests: Get_test_recordinfo shouldn't point into a specific VARIANT. · 27f417eb
    Kevin Puetz authored
    In many cases (in particular when VariantCopy has been used),
    multiple VARIANT structs which contain the same type of record
    will share the same instance of IRecordInfo, just adding refcounts.
    
    RecordClear should not be aware of where the data it's clearing came from,
    and certainly should not be modifying someone else's VARIANT::brecVal.
    This seems to have been intended as a way to make tests more sensitive to
    use-after-free, by overwriting the source pointer with NULL after
    clearing the pointed-to record.
    
    To preserve that sensitivity (if it was indeed the goal), replace the
    hardcoded "0xdeadbeef is valid" check with a "validsrc" address that
    get_test_recordinfo initially agrees to pretend points to a valid record,
    but will stop accepting after a call to RecordClear.
    27f417eb
Name
Last commit
Last update
dlls Loading commit data...
documentation Loading commit data...
fonts Loading commit data...
include Loading commit data...
libs Loading commit data...
loader Loading commit data...
nls Loading commit data...
po Loading commit data...
programs Loading commit data...
server Loading commit data...
tools Loading commit data...
.editorconfig Loading commit data...
.gitlab-ci.yml Loading commit data...
.mailmap Loading commit data...
ANNOUNCE Loading commit data...
AUTHORS Loading commit data...
COPYING.LIB Loading commit data...
LICENSE Loading commit data...
LICENSE.OLD Loading commit data...
MAINTAINERS Loading commit data...
README Loading commit data...
VERSION Loading commit data...
aclocal.m4 Loading commit data...
configure Loading commit data...
configure.ac Loading commit data...