Skip to content

M
mkimage-profiles
Commit 40adf4cc authored by Michael Shigorin's avatar Michael Shigorin
Browse files
Options

main.mk: escalate the comment to a warning

The problem manifests itself when the naive parser ignores any conditions that might have been set in the makefiles included with subsequent attempt to run a target which has its actual rule defined within e.g. "ifdef DEBUG" clause (as is the case for conf.d/test.mk); that will fail with no proper diagnostics currently. Maybe this would be of some use (but then again maybe not): http://stackoverflow.com/questions/3063507/list-goals-targets-in-gnu-make
parent e9f60f00
Show whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
main.mk
View file @ 40adf4cc
...@@ -34,7 +34,8 @@ include $(sort $(wildcard lib/*.mk)) ...@@ -34,7 +34,8 @@ include $(sort $(wildcard lib/*.mk))
include conf.d/*.mk include conf.d/*.mk
include features.in/*/config.mk include features.in/*/config.mk
# starts to look copypastey # FIXME: this is buggy since *.mk can expose parts conditionally
# (e.g. test.mk does DEBUG-only bits) and these will fail
DISTRO_TARGETS := $(shell sed -n 's,^\(distro/[^:.]\+\):.*$$,\1,p' \ DISTRO_TARGETS := $(shell sed -n 's,^\(distro/[^:.]\+\):.*$$,\1,p' \
lib/distro.mk $(wildcard conf.d/*.mk) | sort -u) lib/distro.mk $(wildcard conf.d/*.mk) | sort -u)
VE_TARGETS := $(shell sed -n 's,^\(ve/[^:.]\+\):.*$$,\1,p' \ VE_TARGETS := $(shell sed -n 's,^\(ve/[^:.]\+\):.*$$,\1,p' \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment