hyprland: fix silent error handling

hyprland/actions.go

@@ -67,8 +67,7 @@ func HyprlandModuleStatusCommand(ctx context.Context, cmd *cli.Command) error {
 
 	info := manager.GetModuleInfo(cmd.Args().Get(0), cmd.Bool("user"))
 	if !info.Available {
-		color.Red(locale.T("invalid module name"))
-		return nil
+		return errors.New(locale.T("invalid module name"))
 	}
 	fmt.Println(info.Status.Label)
 	return nil

hyprland/commands.go

@@ -28,8 +28,7 @@ func CommandList() *cli.Command {
 			if err != nil {
 				return fmt.Errorf(locale.T("failed to initialize HyprlandManager: %w"), err)
 			}
-			manager.Save()
-			return nil
+			return manager.Save()
 		},
 		Commands: []*cli.Command{
 			{
@@ -254,11 +253,12 @@ func ShellCompleteVarList(ctx context.Context, cmd *cli.Command) {
 	if cmd.NArg() > 0 {
 		return
 	}
-	manager, _ := NewHyprlandManager()
-
-	data := manager.Vars
+	manager, err := NewHyprlandManager()
+	if err != nil {
+		return
+	}
 
-	for _, v := range data {
+	for _, v := range manager.Vars {
 		fmt.Println(v.Name)
 	}
 }
@@ -268,11 +268,12 @@ func ShellCompleteModule(filter string) func(ctx context.Context, cmd *cli.Comma
 		if cmd.NArg() > 0 {
 			return
 		}
-		manager, _ := NewHyprlandManager()
-
-		userFlag := cmd.Bool("user")
+		manager, err := NewHyprlandManager()
+		if err != nil {
+			return
+		}
 
-		modules := manager.GetModulesList(userFlag, filter)
+		modules := manager.GetModulesList(cmd.Bool("user"), filter)
 		for _, m := range modules {
 			fmt.Println(m.Name)
 		}
@@ -284,11 +285,12 @@ func ShellCompletePlugin(filter string) func(ctx context.Context, cmd *cli.Comma
 		if cmd.NArg() > 0 {
 			return
 		}
+		manager, err := NewHyprlandManager()
+		if err != nil {
+			return
+		}
 
-		manager, _ := NewHyprlandManager()
-
-		data := manager.GetPluginsList(filter)
-		for _, t := range data {
+		for _, t := range manager.GetPluginsList(filter) {
 			fmt.Println(t)
 		}
 	}

hyprland/manager.go

@@ -416,6 +416,8 @@ func (m *HyprlandManager) SetModule(action, module string, user, onlyNew bool) (
 			return fmt.Sprintf(locale.T("Module '%s' disabled"), module), nil
 		}
 
+		return "", fmt.Errorf(locale.T("module '%s' not changed"), module)
+
 	case "remove":
 
 		if info.LineNumber <= 0 {
@@ -426,8 +428,10 @@ func (m *HyprlandManager) SetModule(action, module string, user, onlyNew bool) (
 		m.removeLine(info.LineNumber)
 
 		return fmt.Sprintf(locale.T("Module '%s' removed"), module), nil
+
+	default:
+		return "", fmt.Errorf(locale.T("unsupported action: %s"), action)
 	}
-	return "", nil
 }
 
 func (m *HyprlandManager) enableMessage(module string, disabledGroup []string) string {
@@ -853,9 +857,10 @@ func (m *HyprlandManager) SetPlugin(action string, name string) (string, error)
 			return "", fmt.Errorf("%v (%s)", err, out)
 		}
 		return fmt.Sprintf(locale.T("Plugin '%s' unloaded"), name), nil
-	}
 
-	return "", nil
+	default:
+		return "", fmt.Errorf(locale.T("unsupported action: %s"), action)
+	}
 }
 
 // Vars