• Kubernetes Submit Queue's avatar
    Merge pull request #56690 from redbaron/master · 0ba80021
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Disable session affinity for internal kuberntes service
    
    Under following conditions session affinity leads to a deadlock:
      - Self hosted controller-manager, where it talks to API servers
        via kubernetes service ClusterIP
      - default master-count reconcilier is used
      - --apiserver-count is set to >1 according to the help message
      - number of responsive APIServers goes below `apiserver-count`
      - all controller-managers happen to be hashed to APIServers which
        are down.
    
    What then happens is that controller managers never be able to
    contact APIServer, despite correctly working APIServer available.
    
    Less serious outages also possible for other consumers of kubernetes
    service, such as operators, kube-dns, flannel & calico, etc.  There is
    always non zero chance, that given consumer is hashed  to an apiserver
    which is down.
    
    This reverts PR https://github.com/kubernetes/kubernetes/pull/23129
    
    /sig api-machinery
    CCing:
      -  author and approver of reverted PR: @mikedanese, @lavalamp 
      - other affected users which spoke up: @jsravn, @tatsuhiro-t 
    
    
    ```release-note
    NONE
    ```
    0ba80021
controller.go 11 KB