• Kubernetes Submit Queue's avatar
    Merge pull request #59661 from shyamjvs/fix-profile-gatherer · 4b694186
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 59424, 59672, 59313, 59661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Disable symbol resolution by pprof in profile-gatherer
    
    Because otherwise it is failing while trying to symbolize, due to lack of a kube-apiserver binary locally (as noted by @wojtek-t) within the job pod:
    
    ```
    Local symbolization failed for kube-apiserver: open /usr/local/bin/kube-apiserver: no such file or directory
    ```
    
    This does seem to still produce a graph with all named references - so it seems fine to avoid it. The [documentation](https://github.com/google/pprof/blob/master/doc/pprof.md#symbolization) says:
    
    ```
    pprof can add symbol information to a profile that was collected only with address information. This is useful for profiles for compiled languages, where it may not be easy or even possible for the profile source to include function names or source coordinates.
    ```
    
    So my feeling is that for golang, the function names, etc are included in the profile source.
    
    /cc @wojtek-t @kubernetes/sig-scalability-misc 
    
    ```release-note
    NONE
    ```
    4b694186
profile_gatherer.go 6.07 KB