Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
K
k3s
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Jacklull
  • k3s
  • Repository

Switch branch/tag
  • k3s
  • test
  • e2e
  • framework
  • job
  • wait.go
Find file
BlameHistoryPermalink
  • W. Trevor King's avatar
    test/e2e/upgrades/apps/job: List Pods in failure message · 96b04bfe
    W. Trevor King authored May 09, 2019
    Currently, this test can fail with the not-very-helpful [1,2]:
    
      fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
          <bool>: false
      to be true
    
    Since this test is the only CheckForAllJobPodsRunning consumer, and
    has been since CheckForAllJobPodsRunning landed in 116eda09
    (Implements an upgrade test for Job, 2017-02-22, #41271), this commit
    refactors the function to EnsureJobPodsRunning, dropping the opaque
    boolean, and constructing a useful error summarizing the divergence
    from the expected parallelism and the status of listed Pods.
    
    Thanks to Maciej Szulik for the fixups [3] :).
    
    [1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
    [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
    [3]: https://github.com/wking/kubernetes/pull/1
    96b04bfe
wait.go 5.09 KB
EditWeb IDE

Replace wait.go

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.