• Jiaying Zhang's avatar
    Fixes the races around devicemanager Allocate() and endpoint deletion. · 5514a1f4
    Jiaying Zhang authored
    There is a race in predicateAdmitHandler Admit() that getNodeAnyWayFunc()
    could get Node with non-zero deviceplugin resource allocatable for a
    non-existing endpoint. That race can happen when a device plugin fails,
    but is more likely when kubelet restarts as with the current registration
    model, there is a time gap between kubelet restart and device plugin
    re-registration. During this time window, even though devicemanager could
    have removed the resource initially during GetCapacity() call, Kubelet
    may overwrite the device plugin resource capacity/allocatable with the
    old value when node update from the API server comes in later. This
    could cause a pod to be started without proper device runtime config set.
    
    To solve this problem, introduce endpointStopGracePeriod. When a device
    plugin fails, don't immediately remove the endpoint but set stopTime in
    its endpoint. During kubelet restart, create endpoints with stopTime set
    for any checkpointed registered resource. The endpoint is considered to be
    in stopGracePeriod if its stoptime is set. This allows us to track what
    resources should be handled by devicemanager during the time gap.
    When an endpoint's stopGracePeriod expires, we remove the endpoint and
    its resource. This allows the resource to be exported through other channels
    (e.g., by directly updating node status through API server) if there is such
    use case. Currently endpointStopGracePeriod is set as 5 minutes.
    
    Given that an endpoint is no longer immediately removed upon disconnection,
    mark all its devices unhealthy so that we can signal the resource allocatable
    change to the scheduler to avoid scheduling more pods to the node.
    When a device plugin endpoint is in stopGracePeriod, pods requesting the
    corresponding resource will fail admission handler.
    5514a1f4
manager_test.go 30.6 KB