• Kubernetes Submit Queue's avatar
    Merge pull request #67615 from rphillips/fixes/attach_func_initializer · 5fb32e70
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    attach: Move the AttachFunc default function to the initializer
    
    Fixes a partially constructed AttachOptions
    
    **What this PR does / why we need it**: NewAttachOptions partially constructs an AttachOptions structure. The defaultAttachFunc should be set automatically, so the caller can potentially override the default behavior.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    ```release-note
    NONE
    ```
    
    /cc @kubernetes/sig-cli-api-reviews
    5fb32e70
attach.go 10.5 KB