• Antonio Murdaca's avatar
    pkg: kubelet: do not assume anything about images names · 520b99cd
    Antonio Murdaca authored
    This patch fixes a regression introduced by
    https://github.com/kubernetes/kubernetes/pull/51751 in the CRI
    interface.
    That commit actually changed a unit test where we were previously *not*
    assuming anything about an image name.
    Before that commit, if you send the image "busybox" through the CRI,
    the container runtime receives "busybox". After that patch the
    container runtime gets "docker.io/library/busybox".
    While that may be correct for the internal kube dockershim, in the CRI
    we must not assume anything about image names. The ImageSpec is not
    providing any spec around the image so the container runtime should
    just get the raw image name from the pod spec. Every container runtime
    can handle image names the way it wants. The "docker.io" namespace is
    not at all "standard", CRI-O is not following what the docker UI say
    since that's the docker UI. We should not focus the CRI on wrong UI
    design, especially around a default namespace.
    
    ImageSpec is not standardized yet:
    https://github.com/kubernetes/kubernetes/issues/46255 and
    https://github.com/kubernetes/kubernetes/issues/7203
    
    This is something which should land in 1.9 as well since the regression
    is from 1.8.
    Signed-off-by: 's avatarAntonio Murdaca <runcom@redhat.com>
    520b99cd
image_manager.go 6.3 KB