Merge pull request #45645 from zjj2wry/kubectl-create-quota

Automatic merge from submit-queue (batch tested with PRs 46383, 45645, 45923, 44884, 46294) Fix test not use test flags **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: old code not use test.flags, now use it **Release note**: ```release-note ```

Merge pull request #45645 from zjj2wry/kubectl-create-quota
00acd84b · Kubernetes Submit Queue · GitHub · b7ebdfa9 · 61e5b581 · 00acd84b
Commit 00acd84b authored May 26, 2017 by Kubernetes Submit Queue Committed by GitHub May 26, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

create_quota_test.go pkg/kubectl/cmd/create_quota_test.go +6 -6

No files found.
--- a/pkg/kubectl/cmd/create_quota_test.go
+++ b/pkg/kubectl/cmd/create_quota_test.go
@@ -47,30 +47,30 @@ func TestCreateQuota(t *testing.T) {
 	tf.Namespace = "test"
 	tests := map[string]struct {
-		flags          map[string]string
+		flags          []string
 		expectedOutput string
 	}{
 		"single resource": {
-			flags:          map[string]string{"hard": "cpu=1", "output": "name"},
+			flags:          []string{"--hard=cpu=1"},
 			expectedOutput: "resourcequota/" + resourceQuotaObject.Name + "\n",
 		},
 		"single resource with a scope": {
-			flags:          map[string]string{"hard": "cpu=1", "output": "name", "scopes": "BestEffort"},
+			flags:          []string{"--hard=cpu=1", "--scopes=BestEffort"},
 			expectedOutput: "resourcequota/" + resourceQuotaObject.Name + "\n",
 		},
 		"multiple resources": {
-			flags:          map[string]string{"hard": "cpu=1,pods=42", "output": "name", "scopes": "BestEffort"},
+			flags:          []string{"--hard=cpu=1,pods=42", "--scopes=BestEffort"},
 			expectedOutput: "resourcequota/" + resourceQuotaObject.Name + "\n",
 		},
 		"single resource with multiple scopes": {
-			flags:          map[string]string{"hard": "cpu=1", "output": "name", "scopes": "BestEffort,NotTerminating"},
+			flags:          []string{"--hard=cpu=1", "--scopes=BestEffort,NotTerminating"},
 			expectedOutput: "resourcequota/" + resourceQuotaObject.Name + "\n",
 		},
 	}
 	for name, test := range tests {
 		buf := bytes.NewBuffer([]byte{})
 		cmd := NewCmdCreateQuota(f, buf)
-		cmd.Flags().Set("hard", "cpu=1")
+		cmd.Flags().Parse(test.flags)
 		cmd.Flags().Set("output", "name")
 		cmd.Run(cmd, []string{resourceQuotaObject.Name})