Merge pull request #63459 from resouer/fix-63427

Automatic merge from submit-queue (batch tested with PRs 63598, 63913, 63459, 63963, 60464). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Check nodeInfo before ecache predicate **What this PR does / why we need it**: There's chances during test when nodeInfo is nil which may cause ecache predicate fail with nil pointer. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #63427 **Special notes for your reviewer**: Not sure how to reproduce the original issue yet. i.e. why and when `nodeInfo` will become nil in tests is not clear to me, that's why I label it as WIP. cc @bsalamat who may have more inputs. **Release note**: ```release-note NONE ```

Merge pull request #63459 from resouer/fix-63427
0a2467d8 · Kubernetes Submit Queue · GitHub · 4810b9ba · 8df3ab75 · 0a2467d8
Unverified Commit 0a2467d8 authored May 19, 2018 by Kubernetes Submit Queue Committed by GitHub May 19, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

equivalence_cache.go pkg/scheduler/core/equivalence_cache.go +7 -0

No files found.
--- a/pkg/scheduler/core/equivalence_cache.go
+++ b/pkg/scheduler/core/equivalence_cache.go
@@ -17,6 +17,7 @@ limitations under the License.
 package core

 import (
+	"fmt"
 	"hash/fnv"
 	"sync"

@@ -73,6 +74,12 @@ func (ec *EquivalenceCache) RunPredicate(
 ) (bool, []algorithm.PredicateFailureReason, error) {
 	ec.mu.Lock()
 	defer ec.mu.Unlock()
+
+	if nodeInfo == nil || nodeInfo.Node() == nil {
+		// This may happen during tests.
+		return false, []algorithm.PredicateFailureReason{}, fmt.Errorf("nodeInfo is nil or node is invalid")
+	}
+
 	fit, reasons, invalid := ec.lookupResult(pod.GetName(), nodeInfo.Node().GetName(), predicateKey, equivClassInfo.hash)
 	if !invalid {
 		return fit, reasons, nil