Perform basic validation on K3S_URL in install.sh

This allows us to fail quickly if we're handed a schemeless or plain HTTP URI, rather than having the agent barf when the systemd unit starts. For an operator, this makes for a cleaner error up front and clear messaging for how to fix the situation. Signed-off-by: Josh McSavaney <mcsaucy@csh.rit.edu>

Perform basic validation on K3S_URL in install.sh
12235fe7 · Josh McSavaney · dd25c2b7 · 12235fe7
Commit 12235fe7 authored Jun 25, 2020 by Josh McSavaney
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

install.sh install.sh +3 -0

No files found.
--- a/install.sh
+++ b/install.sh
@@ -153,6 +153,9 @@ setup_env() {
                if [ -z "${K3S_TOKEN}" ] && [ -z "${K3S_CLUSTER_SECRET}" ]; then
                    fatal "Defaulted k3s exec command to 'agent' because K3S_URL is defined, but K3S_TOKEN or K3S_CLUSTER_SECRET is not defined."
                fi
+                if ! echo "${K3S_URL}" | grep -q "^https://"; then
+                    fatal "Only https:// URLs are supported for K3S_URL (have ${K3S_URL})"
+                fi
                CMD_K3S=agent
            fi
        ;;