Merge pull request #45999 from enj/enj/i/custom_resource_name

Automatic merge from submit-queue Remove ObjectNameFunc from custom resources @deads2k as far as I can tell these `ObjectNameFunc`s are unnecessary. Signed-off-by: Monis Khan <mkhan@redhat.com> **Release note**: ``` NONE ```

Merge pull request #45999 from enj/enj/i/custom_resource_name
151846db · Kubernetes Submit Queue · GitHub · d775ff4c · cb132826 · 151846db
Commit 151846db authored May 18, 2017 by Kubernetes Submit Queue Committed by GitHub May 18, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 14 deletions

etcd.go ...-apiextensions-server/pkg/registry/customresource/etcd.go +0 -8

etcd.go ...ions-server/pkg/registry/customresourcedefinition/etcd.go +3 -6

No files found.
--- a/staging/src/k8s.io/kube-apiextensions-server/pkg/registry/customresource/etcd.go
+++ b/staging/src/k8s.io/kube-apiextensions-server/pkg/registry/customresource/etcd.go
@@ -17,7 +17,6 @@ limitations under the License.
 package customresource
 import (
-	"k8s.io/apimachinery/pkg/api/meta"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -41,13 +40,6 @@ func NewREST(resource schema.GroupResource, listKind schema.GroupVersionKind, co
 			ret.SetGroupVersionKind(listKind)
 			return ret
 		},
-		ObjectNameFunc: func(obj runtime.Object) (string, error) {
-			accessor, err := meta.Accessor(obj)
-			if err != nil {
-				return "", err
-			}
-			return accessor.GetName(), nil
-		},
 		PredicateFunc:     strategy.MatchCustomResourceDefinitionStorage,
 		QualifiedResource: resource,

--- a/staging/src/k8s.io/kube-apiextensions-server/pkg/registry/customresourcedefinition/etcd.go
+++ b/staging/src/k8s.io/kube-apiextensions-server/pkg/registry/customresourcedefinition/etcd.go
@@ -35,12 +35,9 @@ func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) *REST
 	strategy := NewStrategy(scheme)
 	store := &genericregistry.Store{
-		Copier:      scheme,
+		Copier:            scheme,
-		NewFunc:     func() runtime.Object { return &apiextensions.CustomResourceDefinition{} },
+		NewFunc:           func() runtime.Object { return &apiextensions.CustomResourceDefinition{} },
-		NewListFunc: func() runtime.Object { return &apiextensions.CustomResourceDefinitionList{} },
+		NewListFunc:       func() runtime.Object { return &apiextensions.CustomResourceDefinitionList{} },
-		ObjectNameFunc: func(obj runtime.Object) (string, error) {
-			return obj.(*apiextensions.CustomResourceDefinition).Name, nil
-		},
 		PredicateFunc:     MatchCustomResourceDefinition,
 		QualifiedResource: apiextensions.Resource("customresourcedefinitions"),