Unverified Commit 1a8f613e authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #62105 from simonswine/automated-cherry-pick-of-#61713-upstream-release-1.10

Automatic merge from submit-queue. Automated cherry pick of #61713: kubectl: fix a panic when createGeneratedObject failed Cherry pick of #61713 on release-1.10. #61713: kubectl: fix a panic when createGeneratedObject failed **Release note**: ```release-note Fix `kubectl run` panic as errors of generated objects were not propagated ```
parents ddc056fb 8ce76784
......@@ -276,14 +276,14 @@ func RunRun(f cmdutil.Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer, cmd *c
params["env"] = cmdutil.GetFlagStringArray(cmd, "env")
allErrs := []error{}
var runObjectMap = map[string]*RunObject{}
var createdObjects = []*RunObject{}
runObject, err := createGeneratedObject(f, cmd, generator, names, params, cmdutil.GetFlagString(cmd, "overrides"), namespace)
if err != nil {
allErrs = append(allErrs, err)
return err
} else {
runObjectMap[generatorName] = runObject
createdObjects = append(createdObjects, runObject)
}
allErrs := []error{}
if cmdutil.GetFlagBool(cmd, "expose") {
serviceGenerator := cmdutil.GetFlagString(cmd, "service-generator")
if len(serviceGenerator) == 0 {
......@@ -293,7 +293,7 @@ func RunRun(f cmdutil.Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer, cmd *c
if err != nil {
allErrs = append(allErrs, err)
} else {
runObjectMap[generatorName] = serviceRunObject
createdObjects = append(createdObjects, serviceRunObject)
}
}
......@@ -345,7 +345,7 @@ func RunRun(f cmdutil.Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer, cmd *c
}
if remove {
for _, obj := range runObjectMap {
for _, obj := range createdObjects {
namespace, err = obj.Mapping.MetadataAccessor.Namespace(obj.Object)
if err != nil {
return err
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment