Unverified Commit 260ca57c authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #72948 from bsalamat/remove_todo

Cleanup a TODO in preemption logic to reflect the current state
parents 9e3b0a0e fa6d17f4
...@@ -1036,10 +1036,11 @@ func selectVictimsOnNode( ...@@ -1036,10 +1036,11 @@ func selectVictimsOnNode(
} }
potentialVictims.Sort() potentialVictims.Sort()
// If the new pod does not fit after removing all the lower priority pods, // If the new pod does not fit after removing all the lower priority pods,
// we are almost done and this node is not suitable for preemption. The only condition // we are almost done and this node is not suitable for preemption. The only
// that we should check is if the "pod" is failing to schedule due to pod affinity // condition that we could check is if the "pod" is failing to schedule due to
// failure. // inter-pod affinity to one or more victims, but we have decided not to
// TODO(bsalamat): Consider checking affinity to lower priority pods if feasible with reasonable performance. // support this case for performance reasons. Having affinity to lower
// priority pods is not a recommended configuration anyway.
if fits, _, err := podFitsOnNode(pod, meta, nodeInfoCopy, fitPredicates, queue, false); !fits { if fits, _, err := podFitsOnNode(pod, meta, nodeInfoCopy, fitPredicates, queue, false); !fits {
if err != nil { if err != nil {
klog.Warningf("Encountered error while selecting victims on node %v: %v", nodeInfo.Node().Name, err) klog.Warningf("Encountered error while selecting victims on node %v: %v", nodeInfo.Node().Name, err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment