Commit 3868417e authored by Daniel Smith's avatar Daniel Smith

Merge pull request #2917 from dchen1107/cleanup

Make httplog more useful by using glog.*Depth.
parents a30b5f5f 83453bae
...@@ -63,7 +63,7 @@ type passthroughLogger struct{} ...@@ -63,7 +63,7 @@ type passthroughLogger struct{}
// Addf logs info immediately. // Addf logs info immediately.
func (passthroughLogger) Addf(format string, data ...interface{}) { func (passthroughLogger) Addf(format string, data ...interface{}) {
glog.Infof(format, data...) glog.InfoDepth(1, fmt.Sprintf(format, data...))
} }
// DefaultStacktracePred is the default implementation of StacktracePred. // DefaultStacktracePred is the default implementation of StacktracePred.
...@@ -148,7 +148,9 @@ func (rl *respLogger) Addf(format string, data ...interface{}) { ...@@ -148,7 +148,9 @@ func (rl *respLogger) Addf(format string, data ...interface{}) {
// Log is intended to be called once at the end of your request handler, via defer // Log is intended to be called once at the end of your request handler, via defer
func (rl *respLogger) Log() { func (rl *respLogger) Log() {
latency := time.Since(rl.startTime) latency := time.Since(rl.startTime)
glog.V(2).Infof("%s %s: (%v) %v%v%v", rl.req.Method, rl.req.RequestURI, latency, rl.status, rl.statusStack, rl.addedInfo) if glog.V(2) {
glog.InfoDepth(1, fmt.Sprintf("%s %s: (%v) %v%v%v", rl.req.Method, rl.req.RequestURI, latency, rl.status, rl.statusStack, rl.addedInfo))
}
} }
// Header implements http.ResponseWriter. // Header implements http.ResponseWriter.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment