Commit 5cc36c9f authored by Jacob Beacham's avatar Jacob Beacham

Bugfix on kubeadm join with non-token discovery.

Without this change, using a non-token discovery mechanism during a join triggers a nil pointer panic (instead of an error message about not being implemented yet).
parent d12d012a
...@@ -131,14 +131,14 @@ func (j *Join) Validate() error { ...@@ -131,14 +131,14 @@ func (j *Join) Validate() error {
// Run executes worked node provisioning and tries to join an existing cluster. // Run executes worked node provisioning and tries to join an existing cluster.
func (j *Join) Run(out io.Writer) error { func (j *Join) Run(out io.Writer) error {
clusterInfo, err := kubenode.RetrieveTrustedClusterInfo(j.cfg.Discovery.Token)
if err != nil {
return err
}
var cfg *clientcmdapi.Config var cfg *clientcmdapi.Config
// TODO: delete this first block when we move Token to the discovery interface // TODO: delete this first block when we move Token to the discovery interface
if j.cfg.Discovery.Token != nil { if j.cfg.Discovery.Token != nil {
clusterInfo, err := kubenode.RetrieveTrustedClusterInfo(j.cfg.Discovery.Token)
if err != nil {
return err
}
connectionDetails, err := kubenode.EstablishMasterConnection(j.cfg.Discovery.Token, clusterInfo) connectionDetails, err := kubenode.EstablishMasterConnection(j.cfg.Discovery.Token, clusterInfo)
if err != nil { if err != nil {
return err return err
...@@ -152,7 +152,7 @@ func (j *Join) Run(out io.Writer) error { ...@@ -152,7 +152,7 @@ func (j *Join) Run(out io.Writer) error {
return err return err
} }
} else { } else {
cfg, err = discovery.For(j.cfg.Discovery) cfg, err := discovery.For(j.cfg.Discovery)
if err != nil { if err != nil {
return err return err
} }
...@@ -161,7 +161,7 @@ func (j *Join) Run(out io.Writer) error { ...@@ -161,7 +161,7 @@ func (j *Join) Run(out io.Writer) error {
} }
} }
err = kubeconfigphase.WriteKubeconfigToDisk(path.Join(kubeadmapi.GlobalEnvParams.KubernetesDir, kubeconfigphase.KubeletKubeConfigFileName), cfg) err := kubeconfigphase.WriteKubeconfigToDisk(path.Join(kubeadmapi.GlobalEnvParams.KubernetesDir, kubeconfigphase.KubeletKubeConfigFileName), cfg)
if err != nil { if err != nil {
return err return err
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment