Unverified Commit 5e072b37 authored by Janet Kuo's avatar Janet Kuo Committed by Christoph Blecker

Test job backoffLimit correctly

parent 83fb1c0a
...@@ -179,7 +179,8 @@ var _ = SIGDescribe("Job", func() { ...@@ -179,7 +179,8 @@ var _ = SIGDescribe("Job", func() {
It("should exceed backoffLimit", func() { It("should exceed backoffLimit", func() {
By("Creating a job") By("Creating a job")
job := framework.NewTestJob("fail", "backofflimit", v1.RestartPolicyNever, 1, 1, nil, 0) backoff := 1
job := framework.NewTestJob("fail", "backofflimit", v1.RestartPolicyNever, 1, 1, nil, int32(backoff))
job, err := framework.CreateJob(f.ClientSet, f.Namespace.Name, job) job, err := framework.CreateJob(f.ClientSet, f.Namespace.Name, job)
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
By("Ensuring job exceed backofflimit") By("Ensuring job exceed backofflimit")
...@@ -187,11 +188,12 @@ var _ = SIGDescribe("Job", func() { ...@@ -187,11 +188,12 @@ var _ = SIGDescribe("Job", func() {
err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, framework.JobTimeout, "BackoffLimitExceeded") err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, framework.JobTimeout, "BackoffLimitExceeded")
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
By("Checking that only one pod created and status is failed") By(fmt.Sprintf("Checking that %d pod created and status is failed", backoff+1))
pods, err := framework.GetJobPods(f.ClientSet, f.Namespace.Name, job.Name) pods, err := framework.GetJobPods(f.ClientSet, f.Namespace.Name, job.Name)
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
Expect(pods.Items).To(HaveLen(1)) Expect(pods.Items).To(HaveLen(backoff + 1))
pod := pods.Items[0] for _, pod := range pods.Items {
Expect(pod.Status.Phase).To(Equal(v1.PodFailed)) Expect(pod.Status.Phase).To(Equal(v1.PodFailed))
}
}) })
}) })
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment